Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Avatar] Support cross origin in useImageLoadingStatus #3261

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Avatar] Support cross origin in useImageLoadingStatus #3261

wants to merge 3 commits into from
+22 −6

Conversation

ozgurozalp
Copy link

Description

Add crossOrigin Support to useImageLoadingStatus Hook

This PR adds crossOrigin support to the useImageLoadingStatus hook to handle images hosted on external domains that require specific crossOrigin settings (anonymous or use-credentials).

By including this option, we ensure broader compatibility with external image sources and resolve potential loading issues.

Note: I haven’t added a test for this as I’m not entirely sure how to approach testing this scenario.

@ozgurozalp ozgurozalp mentioned this pull request Nov 30, 2024
Merged
@ozgurozalp
Copy link
Author

ozgurozalp commented Dec 19, 2024 •
edited
Loading

@chaance can you review?

@ISnackable
Copy link

Nice, hopefully this gets merged soon, I'm having this exact issue as well.

Btw @ozgurozalp, I think you have to assign crossOrigin to the image variable before the image.src line, else it'll hit the cors error. See my image below.

CleanShot 2025-01-05 at 22 04 57

@ozgurozalp
Copy link
Author

Nice, hopefully this gets merged soon, I'm having this exact issue as well.

Btw @ozgurozalp, I think you have to assign crossOrigin to the image variable before the image.src line, else it'll hit the cors error. See my image below.

CleanShot 2025-01-05 at 22 04 57

Yes my friend, you may be right, I fixed that part too.

@naquiroz naquiroz mentioned this pull request Jan 6, 2025
Open
@naquiroz
Copy link

naquiroz commented Jan 13, 2025 •
edited
Loading

@StephenHaney @vladmoroz @lucasmotta @hadihallak @chaance is there a chance that this PR can go in next release?

@mesutcany
Copy link

I need this!

@Vitkonuk
Copy link

when will it be merged?

@yucelutku
Copy link

A solution that will solve my problem too 👍

@izzetcansuzen
Copy link

This will solve my problem, when will it merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenHaney StephenHaney Awaiting requested review from StephenHaney

@vladmoroz vladmoroz Awaiting requested review from vladmoroz

@lucasmotta lucasmotta Awaiting requested review from lucasmotta

@hadihallak hadihallak Awaiting requested review from hadihallak

@chaance chaance Awaiting requested review from chaance

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ozgurozalp @ISnackable @naquiroz @mesutcany @Vitkonuk @yucelutku @izzetcansuzen